Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sentieon Docs #1579

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Update Sentieon Docs #1579

merged 6 commits into from
Dec 9, 2024

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jul 1, 2024 •
edited
Loading

Waiting until we get #1380 up and running.

@edmundmiller edmundmiller self-assigned this Jul 1, 2024
@edmundmiller edmundmiller added this to the 3.5 milestone Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a9a4b7e

+| ✅ 215 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-09 11:06:56

@edmundmiller edmundmiller mentioned this pull request Jul 16, 2024
Merged
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
FriederikeHanssen
FriederikeHanssen previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentieon server is up and running so I think we can merge this.

I have only tested out adding a env config

env {
    SENTIEON_LICENSE = 'IP:PORT'
}

without the secrets, but this works great

@edmundmiller edmundmiller marked this pull request as ready for review August 21, 2024 22:40
@maxulysse
Copy link
Member

Can you update CHANGELOG?

@edmundmiller
Copy link
Contributor Author

@maxulysse As you wish!

@FriederikeHanssen
Copy link
Contributor

@edmundmiller is this ready to go?

maxulysse
maxulysse reviewed Dec 9, 2024
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
@edmundmiller edmundmiller merged commit 2a08c72 into dev Dec 9, 2024
39 checks passed
@edmundmiller edmundmiller deleted the sentieon branch December 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees

@edmundmiller edmundmiller

Labels
sentieon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @maxulysse @FriederikeHanssen