Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing docker.userEmulation #1405

Merged
merged 12 commits into from
Feb 23, 2024
1 change: 0 additions & 1 deletion conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ if (System.getenv('PROFILE')) {
} else if ("$PROFILE" == "docker") {
conda.enabled = false
docker.enabled = true
docker.userEmulation = { params.use_gatk_spark ? false : true }.call()
charliecloud.enabled = false
podman.enabled = false
shifter.enabled = false
Expand Down
1 change: 0 additions & 1 deletion conf/test/cache.config
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ if (System.getenv('PROFILE')) {
} else if ("$PROFILE" == "docker") {
conda.enabled = false
docker.enabled = true
docker.userEmulation = { params.use_gatk_spark ? false : true }.call()
charliecloud.enabled = false
podman.enabled = false
shifter.enabled = false
Expand Down
4 changes: 0 additions & 4 deletions docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -769,10 +769,6 @@ Re-start your session.

Note that the way to increase the open file limit in your system may be slightly different or require additional steps.

### Cannot delete work folder when using docker + Spark

Currently, when running spark-based tools in combination with docker, it is required to set `docker.userEmulation = false`. This can unfortunately causes permission issues when `work/` is being written with root permissions. In case this happens, you might need to configure docker to run without `userEmulation` (see [here](https://github.com/Midnighter/nf-core-adr/blob/main/docs/adr/0008-refrain-from-using-docker-useremulation-in-nextflow.md)).

## How to handle UMIs

Sarek can process UMI-reads, using [fgbio](http://fulcrumgenomics.github.io/fgbio/tools/latest/) tools.
Expand Down
3 changes: 1 addition & 2 deletions nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,9 @@ profiles {
charliecloud.enabled = false
conda.enabled = false
docker.enabled = true
docker.userEmulation = { params.use_gatk_spark ? false : true }.call()
podman.enabled = false
shifter.enabled = false
docker.runOptions = '-u $(id -u):$(id -g)'
docker.runOptions = '--platform=linux/amd64 -e "HOME=${HOME}" -v /etc/passwd:/etc/passwd:ro -v /etc/shadow:/etc/shadow:ro -v /etc/group:/etc/group:ro -v $HOME:$HOME -u $(id -u):$(id -g)'
maxulysse marked this conversation as resolved.
Show resolved Hide resolved
maxulysse marked this conversation as resolved.
Show resolved Hide resolved
singularity.enabled = false
}
arm {
Expand Down
1 change: 1 addition & 0 deletions tests/test_gatk4spark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
tags:
- gatk4spark
- preprocessing
- foo
maxulysse marked this conversation as resolved.
Show resolved Hide resolved
files:
- path: results/csv/markduplicates.csv
md5sum: 0dec46c4dc83acc263efc234805e9349
Expand Down
1 change: 1 addition & 0 deletions tests/test_joint_germline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- germline
- joint_germline
- variant_calling
- foo
maxulysse marked this conversation as resolved.
Show resolved Hide resolved
files:
- path: results/csv/variantcalled.csv
md5sum: d2dffdbd2b4f1f26a06637592d24dab3
Expand Down
Loading