Update modules #1180
Merged
Update modules #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maxulysse
reviewed
Aug 15, 2023
maxulysse
reviewed
Aug 15, 2023
Comment on lines
+7
to
+8
| 'https://depot.galaxyproject.org/singularity/cnvkit:0.9.10--pyhdfd78af_0': | ||
| 'biocontainers/cnvkit:0.9.10--pyhdfd78af_0' }" |
There was a problem hiding this comment.
why not a mulled container here?
Or maybe more, why adding samtools in this module?
There was a problem hiding this comment.
we had this before.: nf-core/modules#3651
There was a problem hiding this comment.
yeah, something weird is happening with the cnvkit modules there
There was a problem hiding this comment.
the lack of consistency is troubling me
…g of ploidy in controlfreec will be part of upcoming release.)
asp8200
commented
Aug 16, 2023
| @@ -2,7 +2,7 @@ process UNTAR { | |||
| tag "$archive" | |||
| label 'process_single' | |||
|
|
|||
| conda "conda-forge::sed=4.7 bioconda::grep=3.4 conda-forge::tar=1.34" | |||
| conda "conda-forge::sed=4.7 conda-forge::grep=3.11 conda-forge::tar=1.34" | |||
There was a problem hiding this comment.
@maxulysse : How would you state that update in the dependencies table?
There was a problem hiding this comment.
grep 3.4 3.11
we haven't reported channel updates
There was a problem hiding this comment.
Should the channel update be reported anywhere?
maxulysse
reviewed
Aug 17, 2023
CHANGELOG.md
Outdated
| | `tiddit` | 3.3.2 | 3.6.1 | | ||
| | Dependency | Old version | New version | | ||
| | ------------------------ | ------------------------- | ------------------------ | | ||
| | `cnvkit` | 0.9.9 (`samtools` 1.16.1) | 0.9.10 (`samtools` 1.17) | |
There was a problem hiding this comment.
not sure about specifying samtools, but it does make sense...
maxulysse
approved these changes
Aug 17, 2023
Co-authored-by: Friederike Hanssen <[email protected]>
Co-authored-by: Friederike Hanssen <[email protected]>
Co-authored-by: Friederike Hanssen <[email protected]>
FriederikeHanssen
approved these changes
Aug 17, 2023
|
@nf-core-bot fix linting pretty please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers: I got into a bit of nastiness with
snpeff_cache- especially insarek.nf. So please check that out.EDIT: Controlfreec-module not updated, since the handling of ploidy won't be part of the upcoming release of Sarek.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).