FEAT: Use annotation-cache and update VEP to v110 #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| "use_annotation_cache_keys": { | ||
| "type": "boolean", | ||
| "fa_icon": "fas fa-toolbox", | ||
| "description": "Use annotation cache keys for snpeff_cache and vep_cache.", |
There was a problem hiding this comment.
can we get a help text with a bit more explanation
There was a problem hiding this comment.
like i am unsure now, if this referes to the new s3 bucket or if I want to define some cache locally or so
There was a problem hiding this comment.
yeah, basically that's because of how snpeff and vep store data, they're made for HPC, and I'm storing on cloud.
Plan would be to extrapolate that in the docs.
But I need to build a website for that.
| @@ -128,6 +128,10 @@ if (params.tools && (params.tools.split(',').contains('ascat') || params.tools.s | |||
| } | |||
| } | |||
|
|
|||
| if ((params.download_cache) && (params.snpeff_cache || params.vep_cache)) { | |||
| error("Please specify either `--download_cache` or `--snpeff_cache`, `--vep_cache`.\nhttps://nf-co.re/sarek/dev/usage#how-to-customise-snpeff-and-vep-annotation") | |||
There was a problem hiding this comment.
did you update these docs already? Quick question how does this work for a cluster wide setup? I am thinking it would make sense to instruct users to predownload this, same as for igenomes and then supply the cache location (maybe sarek specific config specific config, to keep download costs low in terms of time and storage space for users)
There was a problem hiding this comment.
yeah, for a regular HPC, that depends if you build yourself or if you copy annotation_cache.
If you build locally, then no issue, just set up use_annotation_cache_keys to false.
If just basic mirror of annotation_cache then use_annotation_cache_keys should be set to true.
But for now, no other options.
FriederikeHanssen
requested changes
Jul 4, 2023
asp8200
reviewed
Jul 21, 2023
maxulysse
commented
Jul 21, 2023
asp8200
changed the title
Co-authored-by: Friederike Hanssen <[email protected]>
FriederikeHanssen
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).