Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sentieon in diagrams #1111

Merged
merged 1 commit into from
Jun 28, 2023
Merged

added sentieon in diagrams #1111

merged 1 commit into from
Jun 28, 2023

Conversation

nicorap
Copy link

@nicorap nicorap commented Jun 15, 2023

PR checklist

  • [X ] Added Sentieon in the diagrams.
  • [] no bug fixed!
  • [] no new tool
  • no test needed.
  • no code added, just images.
  • yes.
  • docs/usage.md is not updated but not needed.
  • Output Documentation in docs/output.md is not updated but not needed.
  • CHANGELOG.md is not updated but not needed.
  • README.md is is not updated but not needed.

@nicorap nicorap requested a review from maxulysse as a code owner June 15, 2023 11:12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos in the legend:
-> Optionally Sentieon Accelerated

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of issue with formatting, size and fonts, but nothing that we can't fix afterwards

@asp8200 asp8200 merged commit f688889 into nf-core:sentieon Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants