Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds public_aws_ecr profile for using ECR hosted images. #1045

Merged
merged 3 commits into from
May 26, 2023
Merged

Adds public_aws_ecr profile for using ECR hosted images. #1045

merged 3 commits into from
May 26, 2023

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented May 26, 2023 •
edited
Loading

Additions:

  • Adds public_aws_ecr profile which:
    • Sets the default registry to public.ecr.aws
    • Replaces all processes that aren't available on ECR with full URI

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot
Adds public_aws_ecr profile for using ECR hosted images.
0358f26 
Additions:
 - Adds public_aws_ecr profile which:
    - Sets the default registry to public.ecr.aws
    - Replaces all processes that aren't available on ECR with full URI
@adamrtalbot adamrtalbot requested a review from maxulysse as a code owner May 26, 2023 14:41
@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 08a38c9

+| ✅ 153 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-26 15:59:05

@adamrtalbot adamrtalbot merged commit 618071b into nf-core:dev May 26, 2023
@adamrtalbot adamrtalbot deleted the public_aws_ecr_profile branch May 26, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse