Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trace] Add timestamp logging to prover module for better traceability #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuyndoan
Copy link

Dear Team,

I would like to propose adding timestamp logging to prover.rs as an initial step to improve log traceability and debugging capabilities. This change adds timestamps to proof generation logs while maintaining the current log format and structure.

The enhancement aims to provide better visibility into proof timing and execution flow, making it easier to:

  • Track proof generation progress with precise timestamps
  • Debug timing-related issues with orchestrator updates
  • Analyze performance patterns across proof cycles
  • Correlate events across different system components

The implementation is minimally invasive, only adding timestamps while preserving all existing log formatting and behavior.

Changes

  • Added chrono::Local for timestamp generation in prover module
  • Introduced println_with_time helper function and println_time! macro for prover logs
  • Updated existing println statements in prover.rs to include timestamps
  • Maintained all existing log formatting (colors, indentation, symbols)

Example log output:

[2024-12-13 14:30:45.123] ✓ Proved step 0 at 16.81 proof cycles/sec.
[2024-12-13 14:30:45.234] Will try sending update to orchestrator...
show_log_at_prover

Notes

  • No changes to existing functionality, purely logging enhancement
  • Currently only applied to prover module, can extend to other modules if needed
  • Minimal code changes, focusing only on log output format
  • Zero impact on proof generation or verification logic

Thanks

@tuyndoan tuyndoan marked this pull request as draft December 13, 2024 06:03
@tuyndoan tuyndoan marked this pull request as ready for review December 13, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants