Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Constraints (Node and Attr) #66

Merged
merged 8 commits into from
Jul 15, 2024
Merged

add Constraints (Node and Attr) #66

merged 8 commits into from
Jul 15, 2024

Conversation

jagedn
Copy link
Collaborator

@jagedn jagedn commented Jul 14, 2024

Allow to add constraints in Job or Task

Current PR implements Node constraints and a partial list of Attr constraints

@jagedn jagedn requested a review from abhi18av July 14, 2024 21:31
@abhi18av abhi18av linked an issue Jul 15, 2024 that may be closed by this pull request
@abhi18av abhi18av linked an issue Jul 15, 2024 that may be closed by this pull request
@abhi18av abhi18av marked this pull request as draft July 15, 2024 09:38
jagedn and others added 4 commits July 15, 2024 18:13
Signed-off-by: Jorge Aguilera <[email protected]>
Signed-off-by: Jorge Aguilera <[email protected]>
* refactor the package organization to create a separate package for models

* Refactor the test folder and add license headers
Signed-off-by: Jorge Aguilera <[email protected]>
@jagedn jagedn changed the title add Constraints (Node and partial Attr) add Constraints (Node and Attr) Jul 15, 2024
@jagedn
Copy link
Collaborator Author

jagedn commented Jul 15, 2024

Implemented a raw constraint (in node and attr) so users can add custom/specific constraints, for example:

constraints{
   attr {
       raw 'platform.aws.instance-type', '=', 'm4.xlarge'
   }
}

@abhi18av
Copy link
Member

Implemented a raw constraint (in node and attr) so users can add custom/specific constraints, for example:

Ah, this is good! Provides an escape hatch for things we can't foresee for now.

But, as of 08b82b1 is the following working for you with the intended effect?

 ./run-all.sh --skiplocal --build --nfsun --demo

On the Nomad portal, I can't see any of the constraints/attr show up

image

@jagedn
Copy link
Collaborator Author

jagedn commented Jul 15, 2024

the nextflow.config has 2 typos

constraints: {    // wrong, is an assignment "constraints = {"
            attr {
                unique = [hostName:'nomad02']    // typo, hostname is lowercase
            }
        }

once fixed the constraint is applied

imagen

@abhi18av abhi18av assigned abhi18av and jagedn and unassigned abhi18av Jul 15, 2024
@abhi18av abhi18av marked this pull request as ready for review July 15, 2024 19:40
Copy link
Member

@abhi18av abhi18av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I can confirm, that this is working nicely with the our pure fusionfs based sun-nomadlab cluster 🎉

@abhi18av abhi18av merged commit f9d8834 into master Jul 15, 2024
@abhi18av abhi18av deleted the constraints branch July 15, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A mini-DSL for specifying constraints and affinities
2 participants