Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nf-tower plugin to upload logs when early failures #5434

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix nf-tower plugin to upload logs when early failures #5434

merged 2 commits into from
Oct 25, 2024

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented Oct 25, 2024

close #5433

  • Moving the start of LogsCheckpoit thread from onWorkflowBegin to onWorkflowCreate
  • Implementing onWorkflowError

@jorgee jorgee linked an issue Oct 25, 2024 that may be closed by this pull request
Tower plugin is not pushing logs when error on validation #5433
Closed
@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit f4aefe7
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/671b8a746e2bd20008fd0731

@pditommaso
test [e2e prod]
f4aefe7 
Signed-off-by: Paolo Di Tommaso <[email protected]>
@bentsherman
Copy link
Member

bentsherman commented Oct 25, 2024 •
edited
Loading

Good catch. While the workflow.onComplete handler is called regardless of success or error, the onFlowComplete hook in the trace observer is only called on success.

@pditommaso pditommaso merged commit 4222442 into master Oct 25, 2024
22 checks passed
@pditommaso pditommaso deleted the 5433-tower-plugin-is-not-pushing-logs-when-error-on-validation branch October 25, 2024 13:56
alberto-miranda pushed a commit to alberto-miranda/nextflow that referenced this pull request Nov 19, 2024
@jorgee @pditommaso @alberto-miranda
Fix nf-tower plugin to upload logs when early failures (nextflow-io#5434
f653eef 
) [ci fast]



Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tower plugin is not pushing logs when error on validation
3 participants
@jorgee @bentsherman @pditommaso