Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XPath default serializer #5339

Conversation

jorgee
Copy link
Contributor

@jorgee jorgee commented Sep 26, 2024

Add XPath default serializer

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit a7cdfa5
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66fd0c2315cbdb0008aa6a16

@pditommaso
Copy link
Member

Any test unit tests that can replicate the issue and validate the patch?

@jorgee
Copy link
Contributor Author

jorgee commented Sep 26, 2024

Any test unit tests that can replicate the issue and validate the patch?

I have tried to reproduce the error. In fact, there is a unit test checking the XPath serialized and deserialized from a byte array that is the one used in the error in SortFileCollector.saveFile function. This test is not failing even without the no-arg constructor.
I think, the issue is more related to how a particular XPath instance has been serialized that forces Kyro to use the no-args constructor when deserializing in this particular case and not in the others. Finding the particular case could take some time, and I think just adding the default constructor should solve the issue. I can continuing looking for this particular case, but I don't know if it is good to invest more time on it.

@pditommaso
Copy link
Member

Curious to see the error trace. Is there a link to the issue?

@jorgee
Copy link
Contributor Author

jorgee commented Sep 26, 2024

Curious to see the error trace. Is there a link to the issue?

#5208

Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 290f2d0 into master Oct 2, 2024
11 checks passed
@pditommaso pditommaso deleted the 5208-class-cannot-be-created-missing-no-arg-constructor-nextflowfilehttpxpath branch October 2, 2024 09:20
alberto-miranda pushed a commit to alberto-miranda/nextflow that referenced this pull request Nov 19, 2024

Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class cannot be created (missing no-arg constructor): nextflow.file.http.XPath
2 participants