Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to other docs on the failOnIgnore option #5122

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

jfy133
Copy link
Contributor

@jfy133 jfy133 commented Jul 8, 2024

As requested by @ewels .

Note there is an earlier reference to the option in the docs, but I didn't feel it fit in there in the same way, as there is not a particular markdown entry for the specific option on metadata.md

@jfy133 jfy133 requested a review from a team as a code owner July 8, 2024 15:28
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit a09a269
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/668e3f275cef72000865233c
😎 Deploy Preview https://deploy-preview-5122--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jfy133
Copy link
Contributor Author

jfy133 commented Jul 8, 2024

@ewels the page cross-links aren't rendering on the preview, I'm not sure why, I copied and pasted from other examples of such links (although admittedly it doesn't make sense to me how they work)

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think...

docs/process.md Outdated Show resolved Hide resolved
docs/metadata.md Outdated Show resolved Hide resolved
jfy133 and others added 2 commits July 8, 2024 17:55
@adamrtalbot
Copy link
Collaborator

Alternatively this will allow you to customise the text:

: See {ref}`errorStrategy options <process-error-strategy>` for use-cases of this option.

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay it works. You can customise the text using the snippet I shared in a comment.

@jfy133 jfy133 requested review from ewels and pinin4fjords July 10, 2024 08:25
@pditommaso pditommaso merged commit 572f211 into nextflow-io:master Jul 10, 2024
11 checks passed
@jfy133 jfy133 deleted the improve-failonignore branch July 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants