-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate reference docs from manual pages #4766
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
After discussing with Paolo and the team, we are thinking more to organize the docs like the Docker Docs. The key implication for this PR is that there will not be one general "user guide" and "reference". Instead, there will be a "Guides" section which contains many guides targeted to specific use cases, such as a quickstart for each cloud provider, HPC schedulers, etc. The existing "reference" docs are more accurately described as a "manual" which also contains reference material. Instead of trying to factor out the user guide content, I will keep the docs as they are but just try to better separate the reference material from the "manual" pages. I will refactor this PR accordingly and continue to restructure the existing docs, but also carve out a space for the team to start writing the guides. These efforts can be pursued independently, but since they both depend on a new deployment framework, no harm in keeping them together for now. |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Some notes on the Nextflow training and nf-core docs after a brief review:
Because I have pulled out the reference material (config scopes, channel factories, process directives, etc), the manual pages for config, channels, process, etc have a lot more breathing room to give some illustrative examples. As a result, I think the basic training can be condensed significantly by just linking to the docs more instead of duplicating it. Instead it can focus on walking through the writing and testing of a specific pipeline example. |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
After discussing with Paolo, we would like to only keep the manual + reference docs in the Nextflow repo. Additional content like targeted guides and tutorials should be maintained somewhere else and can be combined with the reference docs at build time. To that end I have trimmed this PR to focus on the internal improvements to the existing docs. These changes can be merged independently of other efforts like writing guides, deployment framework, website overhaul, etc. |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso this PR is up to date. Let's get it merged so that we don't have to keep fixing conflicts |
@bentsherman have a look at those conflicts please |
Signed-off-by: Ben Sherman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure feels good and I found it intuitive to find the content I was looking for.
I've left some comments/suggestions that tidy up some inconsistent language and formatting in close proximity on a single page.
A second sanity check would be worth while but otherwise I think it's good to go.
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally managed to went through. It looks excellent. A few comments:
- Fusion docs looks updated. It should be aligned to the upstream
- Plugins would make more sense in "Running pipelines", with the exception of "Wring plugins" that should go into "Contributing"
- Is Workflow Diagram broken?
done
I have reorganized these pages to better separate the user vs developer content. Both pages could be improved and expanded further, but I'd rather save that for a separate PR. For now I just reorganized the content that was already there.
it's working for me locally and in the netlify preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugin sections changes look good to me. A few minor language suggestions.
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Christopher Hakkaart <[email protected]>
This PR reorganizes the docs in a number of ways:
The original exploration was around refactoring the docs into a user guide vs reference manual. After a few iterations, the main focus now is the first two items, separating the reference docs and reorganizing the sections to be more user friendly.