Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate reference docs from manual pages #4766

Merged
merged 40 commits into from
Sep 25, 2024
Merged

Separate reference docs from manual pages #4766

merged 40 commits into from
Sep 25, 2024

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Feb 21, 2024

This PR reorganizes the docs in a number of ways:

  • reorganize manual pages into "Running pipelines" and "Developing pipelines" to be more aligned with the user journey
  • separate reference content (config scopes, process directives, etc) from the main docs
  • improve section on managing dependencies

The original exploration was around refactoring the docs into a user guide vs reference manual. After a few iterations, the main focus now is the first two items, separating the reference docs and reorganizing the sections to be more user friendly.

Signed-off-by: Ben Sherman <[email protected]>
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 22a4a5d
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66f3ffb2b0a8770008d60fcf
😎 Deploy Preview https://deploy-preview-4766--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentsherman bentsherman changed the title User Guide Refactor docs: separate guides, manual, and reference Feb 22, 2024
@bentsherman
Copy link
Member Author

After discussing with Paolo and the team, we are thinking more to organize the docs like the Docker Docs.

The key implication for this PR is that there will not be one general "user guide" and "reference". Instead, there will be a "Guides" section which contains many guides targeted to specific use cases, such as a quickstart for each cloud provider, HPC schedulers, etc.

The existing "reference" docs are more accurately described as a "manual" which also contains reference material. Instead of trying to factor out the user guide content, I will keep the docs as they are but just try to better separate the reference material from the "manual" pages.

I will refactor this PR accordingly and continue to restructure the existing docs, but also carve out a space for the team to start writing the guides. These efforts can be pursued independently, but since they both depend on a new deployment framework, no harm in keeping them together for now.

Signed-off-by: Ben Sherman <[email protected]>
@bentsherman
Copy link
Member Author

Some notes on the Nextflow training and nf-core docs after a brief review:

  • nf-core docs seems to be mostly about nf-core conventions, really only the installation page has some duplication that could be trimmed

  • the advanced and "applied" training guides can be adapted into guides under our proposed structure, pretty straightforward

  • the basic training duplicates a lot of nextflow docs, it should be condensed significantly and become another guide (see notes below)

Because I have pulled out the reference material (config scopes, channel factories, process directives, etc), the manual pages for config, channels, process, etc have a lot more breathing room to give some illustrative examples. As a result, I think the basic training can be condensed significantly by just linking to the docs more instead of duplicating it. Instead it can focus on walking through the writing and testing of a specific pipeline example.

Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@bentsherman bentsherman changed the title Refactor docs: separate guides, manual, and reference Separate reference docs from manual pages Feb 26, 2024
@bentsherman bentsherman marked this pull request as draft February 26, 2024 17:43
@bentsherman
Copy link
Member Author

bentsherman commented Feb 26, 2024

After discussing with Paolo, we would like to only keep the manual + reference docs in the Nextflow repo. Additional content like targeted guides and tutorials should be maintained somewhere else and can be combined with the reference docs at build time.

To that end I have trimmed this PR to focus on the internal improvements to the existing docs. These changes can be merged independently of other efforts like writing guides, deployment framework, website overhaul, etc.

@bentsherman bentsherman marked this pull request as ready for review March 29, 2024 13:08
@bentsherman bentsherman requested a review from a team as a code owner March 29, 2024 13:08
@bentsherman bentsherman requested a review from ewels March 29, 2024 13:08
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@bentsherman
Copy link
Member Author

@pditommaso this PR is up to date. Let's get it merged so that we don't have to keep fixing conflicts

@pditommaso
Copy link
Member

@bentsherman have a look at those conflicts please

Signed-off-by: Ben Sherman <[email protected]>
Copy link
Contributor

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure feels good and I found it intuitive to find the content I was looking for.

I've left some comments/suggestions that tidy up some inconsistent language and formatting in close proximity on a single page.

A second sanity check would be worth while but otherwise I think it's good to go.

docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Show resolved Hide resolved
docs/cli.md Show resolved Hide resolved
docs/sharing.md Outdated Show resolved Hide resolved
docs/sharing.md Outdated Show resolved Hide resolved
docs/process.md Outdated Show resolved Hide resolved
docs/reference/channel.md Outdated Show resolved Hide resolved
docs/reference/stdlib.md Outdated Show resolved Hide resolved
bentsherman and others added 5 commits September 18, 2024 11:08
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally managed to went through. It looks excellent. A few comments:

  • Fusion docs looks updated. It should be aligned to the upstream
  • Plugins would make more sense in "Running pipelines", with the exception of "Wring plugins" that should go into "Contributing"
  • Is Workflow Diagram broken?

@bentsherman
Copy link
Member Author

Fusion docs looks updated. It should be aligned to the upstream

done

Plugins would make more sense in "Running pipelines", with the exception of "Wring plugins" that should go into "Contributing"

I have reorganized these pages to better separate the user vs developer content. Both pages could be improved and expanded further, but I'd rather save that for a separate PR. For now I just reorganized the content that was already there.

Is Workflow Diagram broken?

it's working for me locally and in the netlify preview

Copy link
Contributor

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin sections changes look good to me. A few minor language suggestions.

docs/developer/plugins.md Outdated Show resolved Hide resolved
docs/developer/plugins.md Outdated Show resolved Hide resolved
docs/developer/plugins.md Outdated Show resolved Hide resolved
docs/developer/plugins.md Outdated Show resolved Hide resolved
docs/developer/plugins.md Outdated Show resolved Hide resolved
pditommaso and others added 5 commits September 24, 2024 13:05
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 25e5eba into master Sep 25, 2024
12 checks passed
@pditommaso pditommaso deleted the docs-user-guide branch September 25, 2024 12:23
alberto-miranda pushed a commit to alberto-miranda/nextflow that referenced this pull request Nov 19, 2024

Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Paolo Di Tommaso <[email protected]>
Co-authored-by: Christopher Hakkaart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants