Don't save kebab-case aliases in the params map #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
Confirmed that it works with the test case in the linked issue |
Signed-off-by: Ben Sherman <[email protected]>
|
Simplified it further:
|
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
changed the title
pditommaso
reviewed
Sep 27, 2024
modules/nextflow/src/test/groovy/nextflow/script/ScriptBindingTest.groovy
Outdated
Show resolved
Hide resolved
|
Intellij reports a problem with 
|
|
This PR can be simplified further, I will fix those issues and make a few more edits |
Signed-off-by: Ben Sherman <[email protected]>
pditommaso
approved these changes
Sep 30, 2024
alberto-miranda
pushed a commit
to alberto-miranda/nextflow
that referenced
this pull request
Nov 19, 2024
…w-io#4702 (solve nextflow-io#4033) Signed-off-by: Ben Sherman <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4033
This PR attempts to resolve some quirks with the params map by separating the alias behavior from the read-only behavior. It adds an
AliasMapwhich can be used to create a map that aliases between kebab-case and camelCase. The params map re-uses this class internally.Still need to add some tests.