Add AWS_SESSION_TOKEN when exporting credentials for Fusion #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordi Deu-Pons <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
|
I think we should into a different approach, exposing creds an env vars is not safe |
|
Ok, we discussed it. Agreed a temporary solution since it does not alter the existing problem. We need to look for better long-term alternatives |
pditommaso
pushed a commit
that referenced
this pull request
Dec 17, 2023
Signed-off-by: Jordi Deu-Pons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some scenarios the
AWS_SESSION_TOKENvariable is also needed by Fusion to authenticate AWS.This PR exports this variable if exists and
fusion.exportStorageCredentialsis set totrue.