Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing labels field in Job request for Google Batch #4538

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Nov 23, 2023

This change will add the missing labels to Batch Job request.
Without some of the labels, some Batch side optimization is not recognized.

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit f83ab8c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/655ebbaa7b2c190008ae246c

@pditommaso pditommaso merged commit 627c595 into nextflow-io:master Nov 24, 2023
21 checks passed
@bentsherman
Copy link
Member

@zetxqx do you think we should still add these labels to the allocation policy?

allocationPolicy.putAllLabels(task.config.getResourceLabels())

I'm guessing they are both useful as one is for the job metadata and the other is for the physical resources.

@zetxqx
Copy link
Contributor Author

zetxqx commented Nov 27, 2023

Yep, there are still some labels valuable for allocationPolicy, we might need to expose more fields on the NextFlow side as well. Currently, this is a comprimised solution not breaking things. Will make more change after I understand the nextFlow code base better.

@bentsherman
Copy link
Member

Sure, feel free to ping me if you have questions about the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants