Never say Oops again #4356
Merged
Never say Oops again #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
adamrtalbot
approved these changes
Oct 2, 2023
bentsherman
approved these changes
Oct 2, 2023
modules/nextflow/src/main/groovy/nextflow/util/LoggerHelper.groovy
Outdated
Show resolved
Hide resolved
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Phil Ewels <[email protected]>
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Phil Ewels <[email protected]>
|
Mostly agree, anyhow in most cases they are internal (log-only reported) error messages |
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
Removed |
|
Amazing. Thanks @pditommaso! 🎉 This is one of those tiny little itches that I've been wanting to scratch for years. Feels good that it's done! 🙌🏻 |
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Phil Ewels <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Ben Sherman <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://uxwritinghub.com/error-message-examples/
Saying "Oops" only annoys people more than they would be otherwise 😅
This has bugged me an infinitesimally small amount many thousands of times over the years. Figured it was time to do something about it..