-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSO credentials provider from AWS SDK v2 #4045
Conversation
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Okay, I got it to work with our test SSO user. Run [profile my-sso-profile]
sso_session = 'my-sso-session'
sso_account_id = '...'
sso_role_name = '...'
[sso-session my-sso-session]
sso_start_url = '...'
sso_region = '...'
sso_registration_scopes = 'sso:account:access' You can then run a Nextflow pipeline with You can also run The SSO region is just the region where the SSO user is authenticated. It is separate from the AWS region, so you can use the SSO profile and then specify any other region via |
Excellent. Let's add a section in the docs after "security credentials" about this |
Yes, it is documented there. Also, tests are passing but this "snyk" test is failing, however I can't access it. |
docs/aws.md
Outdated
::: | ||
4. Java System Properties - `aws.accessKeyId`, `aws.secretKey`, and `aws.sessionToken`. | ||
|
||
5. Web Identity Token credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this
@pditommaso regarding your comments, I have no idea if these auth methods work or are practical with Nextflow
I documented them because they are implemented in Nextflow, but I have no attachment to them. Ideally we should either document them or remove them. |
I think AWS_SESSION_TOKEN and web identity token are both related to temporary credentials, so probably not practical for Nextflow. Java system properties should work fine but you might as well use environment variables or Nextflow config. So I'm fine with not documenting these but then we should also remove them from the code 😄 |
The rationale is to document what's expected to be a feature. Some features can be indirectly implemented by the inherited library, but they should not be documented if there are not meant to be exposed as a supported feature. |
Signed-off-by: Paolo Di Tommaso <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Close #2295
I currently can't test it properly because we don't use SSO internally, but we will try to set up a test environment.
@multimeric feel free to give it a try in the meantime.