feat: add remote bin support for TES in a workdir #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherr-dev
force-pushed
the
feat/tes-remote-bin-support
branch
from
f38af82 to
67888f0
Compare
bentsherman
reviewed
Jun 1, 2023
plugins/nf-ga4gh/src/main/nextflow/ga4gh/tes/executor/TesExecutor.groovy
Outdated
Show resolved
Hide resolved
jherr-dev
force-pushed
the
feat/tes-remote-bin-support
branch
from
d0940eb to
888caca
Compare
|
Thanks for working on this. Have you tested it with your own TES backend? Also, could you add a unit test to |
Signed-off-by: Justin Herr <[email protected]>
Signed-off-by: Justin Herr <[email protected]>
Signed-off-by: Justin Herr <[email protected]>
jherr-dev
force-pushed
the
feat/tes-remote-bin-support
branch
from
0016afa to
bc49aae
Compare
Yeah I've tested and it works with my TES backend. I've added a test for the submit function. |
bentsherman
approved these changes
Jun 23, 2023
pditommaso
approved these changes
Jun 29, 2023
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Justin Herr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using remote bin with TES in a shared file system workdir. The shared file system mount on the server running the pipeline needs to be the same the mount in the image, so a mount off root is easiest. Code is based on the AWS Batch plugin's remote bin support.
Also sets the TES name to the task name.
@pditommaso I see you have done all the updates in the plugin repository for the official plugins, do you want/need to handle that or should I create a pr there to go along with this one?