-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add httpConnectTimeout and httpReadTimeout to google config #3974
Conversation
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
plugins/nf-amazon/src/main/nextflow/cloud/aws/config/AwsS3Config.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-amazon/src/test/nextflow/cloud/aws/config/AwsS3ConfigTest.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
Many tests fails with this error
|
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso this one is ready to merge It turns out the API changes were made somewhere between 2.9 and 2.22 . Since google-cloud-storage 2.9 is already an implicit dependency, I just removed it from the build file, tests are passing. |
But some specific API are used from that library, right? If so it's better to include an explicit deps |
8abe53c
to
caea2ba
Compare
Fair enough, I tested with the explicit dependency and it also works, see the second-to-last commit. I tried to trick github by force-removing the last commit, but it's running the tests again anyway |
This reverts commit b20c535.
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
This commits adds the support for AWS Simple Email Service as an alternative transport for sending notification emails from nextflow. The email is sent via AWS SES when using the nf-amazon plugin, and: - the NXF_ENABLE_AWS_SES=true environment variable is set - or, not `mail.smtp` setting is provided and the AWS_REGION or AWS_DEFAULT_REGION is set in the launching environment Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
This commit fixed the access to public AWS S3 buckets when no AWS credentials are available in the hosting environment. It uses a custom credentials provider that fallbacks to `AnonymousAWSCredentials` class when no creds are detected. Signed-off-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
…w-io#3974) Signed-off-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Ben Sherman <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Close #3973