Azure jobs correctly deleted after completion #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to reduce hitting Azure Batch active jobs quota. Fixes nextflow-io#3926 Changes: - Azure Batch jobs are deleted even if a task within fails Adds: - Sets jobs to automatically terminate based on if the tasks within have completed using Azure Batch SDK. This can be configured with config value `azure.batch.terminateJobsOnCompletion` which defaults to true. Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
Signed-off-by: Adam Talbot <[email protected]>
adamrtalbot
force-pushed
the
fix_azure_job_remains_after_failure
branch
from
476b380 to
2959f09
Compare
bentsherman
reviewed
May 10, 2023
plugins/nf-azure/src/main/nextflow/cloud/azure/batch/AzBatchService.groovy
Show resolved
Hide resolved
|
@adamrtalbot Thanks for providing this patch! |
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Changes to reduce hitting Azure Batch active jobs quota. Changes: - Azure Batch jobs are deleted even if a task within fails Adds: - Sets jobs to automatically terminate based on if the tasks within have completed using Azure Batch SDK. This can be configured with config value `azure.batch.terminateJobsOnCompletion` which defaults to true. Signed-off-by: Adam Talbot <[email protected]> Signed-off-by: Adam Talbot <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextflow was leaving Azure Batch jobs around in active state after completion. This does the following:
azure.batch.TerminateJobsOnCompletionis true (default), it will set the job to automatically terminate after all tasks have finished. This no longer counts towards Azure Batch quota.Fixes #3926