Log exception trace in Tower client #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcrespog
force-pushed
the
tower-http-logging
branch
from
d64112d to
d6a7ec6
Compare
|
Oh, and why there's an error if it returns 200? |
I don't know. Hence, the exception trace in order to see what might be going on 😃. |
tcrespog
force-pushed
the
tower-http-logging
branch
from
d6a7ec6 to
7400540
Compare
|
Included in version 23.02.0-edge |
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, an
IOExceptionmight happen when sending a request to Tower even if the returned HTTP code is a successful code such as200 OK:This change logs the exception trace in order to have more debugging information.