Add requirements for container images to run with Nextflow #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Modolo <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
|
Well, these requirements are also listed under this section: https://nextflow.io/docs/latest/tracing.html#tasks So it would be best to list them only once and link to it where necessary. |
|
It makes sense. I will update the section on tracing accordingly. |
section Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
|
Done, @bentsherman. |
bentsherman
reviewed
Jan 31, 2023
modules/nextflow/src/main/groovy/nextflow/container/CharliecloudBuilder.groovy
Outdated
Show resolved
Hide resolved
mribeirodantas
force-pushed
the
add-note-on-creating-container-images
branch
2 times, most recently
from
cad9a84 to
d1f9921
Compare
…o#3477)" This reverts commit 87eb321. Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
This reverts commit d6da43e. Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
mribeirodantas
force-pushed
the
add-note-on-creating-container-images
branch
from
d1f9921 to
4bd4264
Compare
pditommaso
reviewed
Feb 1, 2023
Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Marcel Ribeiro Dantas <[email protected]>
|
Thanks for the feedback, @pditommaso 😄 |
pditommaso
reviewed
Feb 1, 2023
Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
approved these changes
Feb 1, 2023
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
…io#3586) Signed-off-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Marcel Ribeiro-Dantas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are no instructions on what to put in a container image to run with Nextflow in the containers section of the documentation. This Pull Request fixes this issue.