Fix the default for async finalizer (#5013)

Signed-off-by: Paolo Di Tommaso <[email protected]>
nextflow-io · May 22, 2024 · f5fba70 · f5fba70
1 parent e2e6081
commit f5fba70
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/modules/nextflow/src/main/groovy/nextflow/processor/TaskPollingMonitor.groovy b/modules/nextflow/src/main/groovy/nextflow/processor/TaskPollingMonitor.groovy
@@ -118,7 +118,7 @@ class TaskPollingMonitor implements TaskMonitor {
     @Lazy
     private ExecutorService finalizerPool = { session.taskFinalizerExecutorService() }()
 
-    private boolean enableAsyncFinalizer = SysEnv.get('NXF_ENABLE_ASYNC_FINALIZER','false') as boolean
+    private boolean enableAsyncFinalizer = SysEnv.getBool('NXF_ENABLE_ASYNC_FINALIZER',true)
 
     /**
      * Create the task polling monitor with the provided named parameters object.

diff --git a/modules/nf-commons/src/main/nextflow/SysEnv.groovy b/modules/nf-commons/src/main/nextflow/SysEnv.groovy
@@ -49,6 +49,11 @@ class SysEnv {
         return holder.containsKey(name) ? holder.get(name) : defValue
     }
 
+    static boolean getBool(String name, boolean defValue) {
+        final result = get(name,String.valueOf(defValue))
+        return Boolean.parseBoolean(result)
+    }
+
     static void push(Map<String,String> env) {
         history.push(holder.getTarget())
         holder.setTarget(env)

diff --git a/modules/nf-commons/src/test/nextflow/SysEnvTest.groovy b/modules/nf-commons/src/test/nextflow/SysEnvTest.groovy
@@ -18,6 +18,7 @@
 package nextflow
 
 import spock.lang.Specification
+import spock.lang.Unroll
 
 /**
  *
@@ -54,4 +55,24 @@ class SysEnvTest extends Specification {
         SysEnv.get('HOME') == System.getenv('HOME')
 
     }
+
+    @Unroll
+    def 'should get bool value' () {
+        given:
+        SysEnv.push(STATE)
+
+        expect:
+        SysEnv.getBool('FOO', DEF) == EXPECTED
+
+        where:
+        STATE           | DEF       | EXPECTED
+        [:]             | false     | false
+        [FOO:'false']   | false     | false
+        [FOO:'true']    | false     | true
+        and:
+        [:]             | true      | true
+        [FOO:'false']   | false     | false
+        [FOO:'true']    | true      | true
+
+    }
 }