Fix the cleanup of local secret file (#5061)

Signed-off-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Dr Marco Claudio De La Pierre <[email protected]> Co-authored-by: Dr Marco Claudio De La Pierre <[email protected]>
nextflow-io · Jun 17, 2024 · e28537c · e28537c
1 parent 38434b8
commit e28537c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/modules/nextflow/src/main/groovy/nextflow/secret/LocalSecretsProvider.groovy b/modules/nextflow/src/main/groovy/nextflow/secret/LocalSecretsProvider.groovy
@@ -31,7 +31,6 @@ import nextflow.Const
 import nextflow.SysEnv
 import nextflow.exception.AbortOperationException
 import nextflow.exception.ProcessUnrecoverableException
-import nextflow.util.CacheHelper
 import nextflow.util.Escape
 /**
  * Implements a secrets store that saves secrets into a JSON file save into the
@@ -198,11 +197,13 @@ class LocalSecretsProvider implements SecretsProvider, Closeable {
         if( !secretsMap )
             return null
 
-        final name = ".nf-${CacheHelper.hasher(secretsMap.values()).hash()}.secrets"
+        final name = ".nf-${UUID.randomUUID().toString()}.secrets"
         final path = storeFile.parent.resolve(name)
         if( path.exists() ) {
             // make sure the file can only be accessed by the owner user
             path.setPermissions(ONLY_OWNER_PERMS)
+            // remove it on completion
+            path.toFile().deleteOnExit()
             return path
         }
 
@@ -215,6 +216,9 @@ class LocalSecretsProvider implements SecretsProvider, Closeable {
         // make sure the file can only be accessed by the owner user
         path.setPermissions(ONLY_OWNER_PERMS)
         path.text = result
+        // remove it on completion
+        path.toFile().deleteOnExit()
+        // return the temp path
         return path
     }
 }