Skip to content

Commit

Permalink
Remove invalid equals char (#5414) [ci fast]
Browse files Browse the repository at this point in the history
The equals character from nf-core modules/local/hicpro/dnase_mapping_stats.nf causes pipeline to crash on SGE executor.

Add "=" to list of invalid chars

Signed-off-by: Matthew A Richardson <[email protected]>
  • Loading branch information
mr83-uw authored Oct 21, 2024
1 parent 500f49c commit 7f39e6e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ abstract class AbstractGridExecutor extends Executor {

protected Duration queueInterval

private final static List<String> INVALID_NAME_CHARS = [ " ", "/", ":", "@", "*", "?", "\\n", "\\t", "\\r" ]
private final static List<String> INVALID_NAME_CHARS = [ " ", "/", ":", "@", "*", "?", "\\n", "\\t", "\\r", "=" ]

private Map lastQueueStatus

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ class AbstractGridExecutorTest extends Specification {
def 'should remove invalid chars from name' () {

given:
def task = new TaskRun(name: 'task 90 (foo:bar/baz)')
def task = new TaskRun(name: 'task 90 = (foo:bar/baz)')
def exec = [:] as AbstractGridExecutor

expect:
exec.getJobNameFor(task) == 'nf-task_90_(foo_bar_baz)'
exec.getJobNameFor(task) == 'nf-task_90___(foo_bar_baz)'

}

Expand Down

0 comments on commit 7f39e6e

Please sign in to comment.