Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(neon_framework): Cleanup version checks #2027

Merged
merged 3 commits into from
May 13, 2024

Conversation

provokateurin
Copy link
Member

Exposes all checks which will be necessary for apps to check what version is actually used.

@provokateurin provokateurin requested a review from Leptopoda May 10, 2024 16:23
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 29.31%. Comparing base (09ddf6f) to head (f699c8f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
+ Coverage   28.94%   29.31%   +0.37%     
==========================================
  Files         250      249       -1     
  Lines       84422    84425       +3     
==========================================
+ Hits        24432    24746     +314     
+ Misses      59990    59679     -311     
Flag Coverage Δ *Carryforward flag
dynamite 31.00% <ø> (ø) Carriedforward from 09ddf6f
dynamite_end_to_end_test 61.47% <ø> (ø) Carriedforward from 09ddf6f
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 09ddf6f
neon_dashboard 92.56% <ø> (ø)
neon_framework 38.32% <0.00%> (+0.03%) ⬆️
neon_talk 96.32% <ø> (ø)
nextcloud 26.12% <85.71%> (+0.43%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from 09ddf6f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/nextcloud/lib/src/helpers/core.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/helpers/common.dart 87.50% <66.66%> (-12.50%) ⬇️
packages/neon_framework/lib/src/pages/home.dart 0.00% <0.00%> (ø)
...ework/lib/src/pages/login_check_server_status.dart 0.00% <0.00%> (ø)
packages/neon_framework/lib/src/blocs/apps.dart 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@provokateurin provokateurin force-pushed the refactor/neon_framework/cleanup-version-checks branch from 8a10604 to f699c8f Compare May 13, 2024 12:37
@provokateurin provokateurin requested a review from Leptopoda May 13, 2024 12:37
@provokateurin provokateurin enabled auto-merge May 13, 2024 12:42
@provokateurin provokateurin merged commit 64ff66b into main May 13, 2024
10 checks passed
@provokateurin provokateurin deleted the refactor/neon_framework/cleanup-version-checks branch May 13, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants