Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_talk): Add room list #1657

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

provokateurin
Copy link
Member

Extracted/rewritten from #366
Towards #356

@Leptopoda
Copy link
Member

Mostly UI stuff and some minor code style.
I know that you are trying to get things done one step at a time but let's try to also do the UI right from the beginning.

@provokateurin provokateurin force-pushed the feat/neon_talk/room-list branch from 8905c6a to 3dca169 Compare February 25, 2024 21:41
@provokateurin
Copy link
Member Author

I implemented the unread indicator a bit different than you suggested, but I think it works pretty well this way.
Please note that the actual rendering of the message is not implemented yet (e.g. mentions or files won't work). That will be done in a different PR when the actual chat layout will be implemented.

@provokateurin
Copy link
Member Author

Hm should the indirect mention also show the @? I'm not sure how this is best handled, as @room can sometimes be very important and sometimes be used for no good reason. Maybe this should be implemented as an option to be let the user chose what they prefer.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to assign the subscription.
Other than that let's get it done.

packages/neon/neon_talk/lib/src/pages/main.dart Outdated Show resolved Hide resolved
Signed-off-by: provokateurin <[email protected]>
@provokateurin provokateurin force-pushed the feat/neon_talk/room-list branch from 7e995b5 to 950fd36 Compare February 26, 2024 11:09
@provokateurin provokateurin merged commit 8c19800 into main Feb 26, 2024
8 checks passed
@provokateurin provokateurin deleted the feat/neon_talk/room-list branch February 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants