-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support endpoints with password confirmation #1492
Comments
Let's see where this goes nextcloud/server#43000 |
Ok, so this is actually a bug in the server auth logic. I will make a fix and then we have to wait for new releases of all the versions we support :/ |
This will fix it nextcloud/server#43034 |
In the end we went with nextcloud/server#43668. |
Is there any way we can unblock this? I think #1580 should make this really easy. |
No this is different from the WebDAV thing. There is no way around this, it will only be available on server 29+. |
This can be implemented now (but only on 29+) |
I thought this would be not so easy to implement, but we can simply assume that only API endpoints called within wrapAction can trigger the password confirmation. We can simply catch the error there and show the dialog and afterwards retry. I first thought it would be necessary to mess around with the RequestManager so it also supports password confirmation for the cached endpoints, but that is simply not required. |
Actually done already, just not in the framework so far (I'm working on it). |
To use those endpoints the password has to be entered by the user and sent to https://github.com/nextcloud/server/blob/1612d025cf21ac0ae70327c46dd59be66c096627/core/Controller/LoginController.php#L362.
This endpoint is currently not reachable for us and we would need to support CSRF endpoints too (which is some more work).
The better approach would probably be to open up the endpoint and allow us to use it.
The text was updated successfully, but these errors were encountered: