fix #1 missing HTTP timeout

newsbeam · May 31, 2020 · d804abd · d804abd
1 parent 4aa2590
commit d804abd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/nm_feedfinder/nm_feedfinder.py b/nm_feedfinder/nm_feedfinder.py
@@ -15,6 +15,7 @@
 from bs4 import BeautifulSoup
 import requests
 
+TIMEOUT = 3
 
 def feeds(address: str) -> List[str]:
     # Python dictionaries are ordered so this serves us as an ordered set.
@@ -46,7 +47,7 @@ def find_links(sesh: requests.Session, url: ParseResult) -> List[str]:
     links = []
 
     try:
-        response = sesh.get(urlunparse(url), timeout=3)
+        response = sesh.get(urlunparse(url), timeout=TIMEOUT)
         response.raise_for_status()
     except requests.exceptions.RequestException:
         return []
@@ -130,7 +131,7 @@ def try_hrefs(sesh: requests.Session, url: ParseResult, soup: BeautifulSoup) ->
 
 def could_be_feed(sesh: requests.Session, url: str) -> bool:
     try:
-        response = sesh.get(url)
+        response = sesh.get(url, timeout=TIMEOUT)
         response.raise_for_status()
     except requests.exceptions.RequestException:
         return False

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
     name='nm_feedfinder',
     packages=['nm_feedfinder'],
-    version='0.1',
+    version='0.2',
     license='ISC',
     description='Find Atom/RSS links of a website given a URL',
     author='newsmail.today',