Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exclude option to custom config; updated documentation #36

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

smcelhinney
Copy link

Added an extra property for configuring a blacklist (environment properties to remove from the configuration). Useful in the context of Google Cloud Functions where NODE_ENV is not an allowable environment variable

@colynb
Copy link
Collaborator

colynb commented Feb 2, 2020

@hubspotdev @JakeChampion @smcelhinney Thanks for this PR. I haven't been a great steward of this project because I've been very nervous about the potential of breaking changes. There are a lot of developers who depend on this in ways I can't possibly imagine and so any change, even small and seemingly helpful could have negative impacts on people. So I tend to ignore these instead of responding. Sorry about that. With that said, looking at this, it doesn't appear that it could be a breaking change. Give me a few more mins to review this.

@colynb colynb merged commit ba68bcc into neverendingqs:master Feb 2, 2020
@gasp
Copy link

gasp commented Feb 2, 2020

This also solves this issue: when you are storing AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY (in local env) into your .env those env vars are bubbling up to the lambda function and causing this error.

An error occurred: HelloLambdaFunction - Lambda was unable to configure your environment variables because the environment variables you have provided contains reserved keys that are currently not supported for modification. Reserved keys used in this request: AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 1234567a-1234-1234-1234-aa1111111aa1).

I am putting the full error message so that it will be indexed by search engines and avoid headaches to a lot of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants