-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cornerstone
: Display NIfTI and dicom image previews
#30
base: main
Are you sure you want to change the base?
Conversation
cornerstone
: Display NIfTI and dicom image previews
As a reminder to the future: I was very confused by the current rewrite Cornerstone is going through. It went from It turns out the new version is at best unfinished and at worst vaporware, since not even the flagship app currently uses the rewrite (it's still on 2.6.1) and neither has the author of the NIfTI plugin ported to the new API (even though that plugin has started being published under the new namespace at The upshot is that if the dependencies look inconsistent to you: it's because they are. For future reference: the way I actually figured out how to use this plugin was with the help of GitHub's downstream tab; it helped me find ChRIS_UI whose package.json clearly shows a working configuration and code shows how to actually use all the different filetypes together. |
Testing ⚔️I don't know how to write tests for this since it's mostly frontend code so I'm just not going to do it. I don't think upstream even bothers to test the frontend automatically that much, there only really seems to be these two files: which don't actually test loading any pages or images, they are just unit tests on some utils that happen to be in javascript instead of go. |
e4d5900
to
79f50ba
Compare
Oh, whoops. Looks like Gitea has a hook for doing just this that can be configured via app.ini. It would be something like
and then we would have to make sure that cornerstone.js and everything else it needs is in |
eb1612f
to
d26338a
Compare
There is a competitor, (thanks @valosekj for the tip): https://brainsprite.github.io/. We used this in the past: spine-generic/spine-generic#218; it's live on https://spine-generic.readthedocs.io/data-acquisition.html#example-of-datasets. I am not motivated to rewriting what I already have working, and I found something to support my bias: brainsprite requires server-side pre-processing:
We'd need a route that turns a .nii.gz image into a .jpg of stitched together sprites, and maybe a place on-disk to cache those, separate from the usual Gitea folders. This is possible, but complicates things a lot. |
196a603
to
e0ecfa3
Compare
0e3b839
to
cd4a7e1
Compare
Another potential competitor is NiiVue. It is used, for example, by AFNI QC HTML report; see |
Lovely, good find! |
07c51e8
to
8bfa583
Compare
) Step one for a GitHub like commit status check ui: ![image](https://github.com/go-gitea/gitea/assets/18380374/22953b88-1f91-4d19-bc57-ad92d33fa11f) ![image](https://github.com/go-gitea/gitea/assets/18380374/78572a49-c9b0-472b-86a8-8293197e807b) ![image](https://github.com/go-gitea/gitea/assets/18380374/bc5c8d1c-2ab5-4b03-b8c6-20c34b86d856) Step two: ![image](https://github.com/go-gitea/gitea/assets/18380374/938b359e-8823-4192-b82d-55fa40b986fd) ![image](https://github.com/go-gitea/gitea/assets/18380374/2de5bb8f-40f5-462a-8d6d-bac13a32bc2a) The design now will list all commit status checks which takes too much space. This is a pre-improve for go-gitea#26247 --------- Co-authored-by: delvh <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
…unactive auth source (go-gitea#27798) The steps to reproduce it. First, create a new oauth2 source. Then, a user login with this oauth2 source. Disable the oauth2 source. Visit users -> settings -> security, 500 will be displayed. This is because this page only load active Oauth2 sources but not all Oauth2 sources.
We should not use `asset.ID` in DownloadFunc because DownloadFunc is a closure. https://github.com/go-gitea/gitea/blob/1bf5527eac6b947010c8faf408f6747de2a2384f/services/migrations/gitea_downloader.go#L284-L295 A similar bug when migrating from GitHub has been fixed in go-gitea#14703. This PR fixes the bug when migrating from Gitea and GitLab.
This PR is a small refactor to merge removeOrgUser into RemoveOrgUser.
Remove the "tabindex" from some form buttons on the "diff box" / "issue view content" page, let the browser use the default tab order. --------- Co-authored-by: Gusted <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Revert the workaround of go-gitea#26409 and fix go-gitea#26411, update github.com/gliderlabs/ssh to include gliderlabs/ssh@02f9d57
Use CornerstoneJS to render previews of .nii and .dcm on the web, making Gitea more helpful for clinicians and researchers building medical databases.
Here's a DICOM:
and here's a NIfTI:
Fixes #23