nrn_setup: use std::vector for cell_groups (dat_files)

[ferdonline]

Context

Coreneuron nrn_setup uses a plain malloc'd array for holding the input data cell groups (from files.dat).
These arrays, besides being plain old and not self managed, could not grow and had a static size of nfiles/nranks + 1.

However, in the view of the upcoming load balanced input data, each rank may hold a different count of cell groups. Those changes will come as a follow-up PR.

This PR

Refactors this part of the code to replace the data structure by an std::vector, which

• grows as required and auto deallocs
• avoids the book-keeping of the size as a separate variable

[azure-pipelines]

✔️ d05e252 -> Azure artifacts URL

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.06%. Comparing base (de07242) to head (1853c77).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   67.06%   67.06%   -0.01%     
==========================================
  Files         572      572              
  Lines      111073   111074       +1     
==========================================
  Hits        74488    74488              
- Misses      36585    36586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azure-pipelines]

✔️ 38baa26 -> Azure artifacts URL

[azure-pipelines]

✔️ 4e0e064 -> Azure artifacts URL

[azure-pipelines]

✔️ 86be204 -> Azure artifacts URL

[azure-pipelines]

✔️ 63a32f6 -> Azure artifacts URL

[ferdonline]

@1uc anything missing here?

[1uc]

AFAICT, this is now a refactoring that adds more RAII and other improvements, but doesn't seem to have any functional change.

[ferdonline]

Indeed, there should be no functional changes, including preallocating the vector with the same size as the original array

[azure-pipelines]

✔️ 0f55dd6 -> Azure artifacts URL

[azure-pipelines]

✔️ 1033a0c -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[azure-pipelines]

✔️ 1853c77 -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #240248 (:no_entry:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ⛔ test:neuron:nmodl:nvhpc:omp:legacy
• ⛔ test:neuron:nmodl:nvhpc:omp