added simple sys.getrefcount tests of current baseline #3030
Conversation
|
|
||
| #todo: need to find hoc_built_in_symlist values | ||
|
|
||
| # not sure what the purpose of this is; return a dict of |
There was a problem hiding this comment.
This is vital, it's how you discover (some of) the available "things" like mechanisms, or methods (along with some things that aren't supposed to be there).
There was a problem hiding this comment.
Hmm, that's the last resort, normally I would expect dir() to be used, which relies on Py_tp_methods and things like Py_tp_getset.
Anyways, not important for this review, I will remove the not sure as it's not relevant.
|
|
||
| def test_section(): | ||
| section = h.Section(name='section') | ||
| assert sys.getrefcount(section) == 2 |
There was a problem hiding this comment.
Very nice. The following tedious proposition:
| assert sys.getrefcount(section) == 2 | |
| base_refcount = 2 | |
| assert sys.getrefcount(section) == base_refcount |
Here it's pointless. It does protect a little against there currently being 2 references (when I can only see 1).
There was a problem hiding this comment.
the extra one is the call to sys.getrefcount, I'll make a comment.
I thought about having a base_refcount like variable, so that's 2 of us.
I'll make the change.
|
|
||
| # {Py_tp_repr, (void*) pysec_repr_safe}, | ||
| repr(section) | ||
| assert sys.getrefcount(section) == 2 |
There was a problem hiding this comment.
Here's where we gain something:
assert sys.getrefcount(section) == base_refcount
which one would interpret as base_refcount + 0, i.e. it correctly returned to +0.
| #static PyType_Slot nrnpy_AllSegOfSecIterType_slots[] = { | ||
| it = section.allseg() | ||
| assert sys.getrefcount(it) == 2 | ||
| assert sys.getrefcount(section) == 3 |
There was a problem hiding this comment.
| assert sys.getrefcount(section) == 3 | |
| assert sys.getrefcount(section) == base_refcount + 1 |
The +1, because we're holding one additional reference.
|
✔️ cf1da10 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
mgeplf
force-pushed
the
add-python-refcount-tests
branch
from
cf1da10 to
766bdff
Compare
|
✔️ 766bdff -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ cf7ffa3 -> Azure artifacts URL |
|
|
✔️ 416cc15 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3030 +/- ##
==========================================
+ Coverage 67.27% 67.32% +0.05%
==========================================
Files 572 572
Lines 104928 104923 -5
==========================================
+ Hits 70591 70643 +52
+ Misses 34337 34280 -57 ☔ View full report in Codecov by Sentry. |
No description provided.