Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert actions to Enum #90

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Convert actions to Enum #90

merged 3 commits into from
Jan 21, 2022

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Jan 7, 2022

fixes #86

Technically it's not a real enum because using when using an enum the value doesn't translate directly to a string but I think the result is the same.

@dgarros dgarros requested a review from glennmatthews as a code owner January 7, 2022 21:28
diffsync/enum.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews previously approved these changes Jan 21, 2022
diffsync/helpers.py Outdated Show resolved Hide resolved
@dgarros
Copy link
Contributor Author

dgarros commented Jan 21, 2022

@glennmatthews I've updated this PR to use a proper Enum, ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Enum to track the valid type of Actions
2 participants