Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade structlog, packaging dependencies #211

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

jamesharr
Copy link
Contributor

@jamesharr jamesharr commented Mar 2, 2023

This upgrades the structlog and packaging dependencies. I also bumped the patch version number. No clue if this is appropriate or not.

This came about because I ran into an issue where one tool we use during development (black version 23) requires packaging >= 22.0, and our project is making use of structlog 22.3.0.

At first glance, these packages seem fairly API compatible between versions, so my logic was to loosen up the requirement ranges a bit and allow further upgrades.

Again, I'm not sure if this is correct behavior or not, but I figured I'd throw this out there and see where the conversation goes.

@Kircheneer
Copy link
Collaborator

I am unsure why black is failing in the CI, but would you mind running black on the code once and pushing that? That should fix the failing CI step.

As to bumping the patch version, can you revert that change? This should happen in a separate release PR.

@jamesharr
Copy link
Contributor Author

I'll get it updated today in a little bit.

I know what's going on with black, they do a style change once a year when they bump the major rev. 23 introduces a change that removes an empt.y newline at the start of a code block.

I'll have more info on that when I update the PR

@jamesharr
Copy link
Contributor Author

jamesharr commented Mar 2, 2023

review suggestions implemented

If you're curious, this is the black 23.x style change I was referring to, but it seems like the changes are more subtle here...
psf/black#3035

@Kircheneer
Copy link
Collaborator

There are still some weird CI things happening. I have updated the CI setup in the following PR: #212 Once that's in, you should be able to rebase and then be good.

@Kircheneer
Copy link
Collaborator

PR is in, just rebase onto develop now and it should work.

@jamesharr
Copy link
Contributor Author

Alright, I think/hope it should be good now

@Kircheneer
Copy link
Collaborator

LGTM @jamesharr! Thanks for staying patient here.

@Kircheneer Kircheneer merged commit 95fb491 into networktocode:develop Mar 3, 2023
@jamesharr jamesharr mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants