-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade structlog, packaging dependencies #211
Conversation
I am unsure why black is failing in the CI, but would you mind running As to bumping the patch version, can you revert that change? This should happen in a separate release PR. |
I'll get it updated today in a little bit. I know what's going on with black, they do a style change once a year when they bump the major rev. 23 introduces a change that removes an empt.y newline at the start of a code block. I'll have more info on that when I update the PR |
d65c79b
to
4d96f55
Compare
review suggestions implemented If you're curious, this is the black 23.x style change I was referring to, but it seems like the changes are more subtle here... |
There are still some weird CI things happening. I have updated the CI setup in the following PR: #212 Once that's in, you should be able to rebase and then be good. |
PR is in, just rebase onto develop now and it should work. |
4d96f55
to
188cf44
Compare
Alright, I think/hope it should be good now |
LGTM @jamesharr! Thanks for staying patient here. |
This upgrades the structlog and packaging dependencies. I also bumped the patch version number. No clue if this is appropriate or not.
This came about because I ran into an issue where one tool we use during development (black version 23) requires packaging >= 22.0, and our project is making use of structlog 22.3.0.
At first glance, these packages seem fairly API compatible between versions, so my logic was to loosen up the requirement ranges a bit and allow further upgrades.
Again, I'm not sure if this is correct behavior or not, but I figured I'd throw this out there and see where the conversation goes.