-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dakonr dx sync to #188
Feature/dakonr dx sync to #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dakonr please run black on the code and make sure the rest of the CI passes, then we're good to go. Thanks! |
sorry, there were still some blanks on init.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still complaining, pylint stage this time. You can run that locally with invoke pylint
to make sure it passes.
Hi, I had to move the pylint disable comment to the first line of the function definition (in the development branch it is still at the end). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dakonr absolutely no worries - I think discoverability of the |
sync_from
andsync_to
to return the diff and the status of the sync #77 Improving the DX by returning the diff in the sync_to and sync_from methods.