Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dakonr dx sync to #188

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

dakonr
Copy link
Contributor

@dakonr dakonr commented Nov 27, 2022

Kircheneer
Kircheneer previously approved these changes Nov 28, 2022
Copy link
Collaborator

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer
Copy link
Collaborator

@dakonr please run black on the code and make sure the rest of the CI passes, then we're good to go. Thanks!

@dakonr
Copy link
Contributor Author

dakonr commented Nov 28, 2022

sorry, there were still some blanks on init.py
should be fine now.

Copy link
Collaborator

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still complaining, pylint stage this time. You can run that locally with invoke pylint to make sure it passes.

@dakonr
Copy link
Contributor Author

dakonr commented Nov 28, 2022

Hi, I had to move the pylint disable comment to the first line of the function definition (in the development branch it is still at the end).
As a new developer on the codebase I had no experience with invoke. All tasks at "invoke tests" passed on my local machine. I hope you had not that trouble with my contribution, I'm usually working with a GitLab CI toolchain.

Copy link
Collaborator

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer
Copy link
Collaborator

Hi, I had to move the pylint disable comment to the first line of the function definition (in the development branch it is still at the end). As a new developer on the codebase I had no experience with invoke. All tasks at "invoke tests" passed on my local machine. I hope you had not that trouble with my contribution, I'm usually working with a GitLab CI toolchain.

@dakonr absolutely no worries - I think discoverability of the invoke tasks for linting is a little lacking, I will add that to the README. Thanks for the contribution!

@Kircheneer Kircheneer merged commit c91f2c7 into networktocode:develop Nov 29, 2022
@dakonr dakonr deleted the feature/dakonr-dx-sync_to branch December 3, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sync_from and sync_to to return the diff and the status of the sync
2 participants