-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods for get or update instantiate_model #182
Add methods for get or update instantiate_model #182
Conversation
b072ec1
to
d9d47f2
Compare
Doh’, this doesn’t make sense. When I went to use this, I realized the method was conditionally adding. This is just redundant |
Double Doh'!! ok, red herring, there was an issue, I didn't see where the code was actually issuing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, I just have two minor suggestions.
cfd4f8a
to
e7d23f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.