Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for get or update instantiate_model #182

Merged

Conversation

itdependsnetworks
Copy link
Contributor

No description provided.

@itdependsnetworks
Copy link
Contributor Author

Doh’, this doesn’t make sense. When I went to use this, I realized the method was conditionally adding. This is just redundant

@itdependsnetworks
Copy link
Contributor Author

Double Doh'!! ok, red herring, there was an issue, I didn't see where the code was actually issuing a self.add (it was nested more), so I thought it was adding.... it was :)

diffsync/store/__init__.py Outdated Show resolved Hide resolved
diffsync/store/__init__.py Outdated Show resolved Hide resolved
diffsync/store/__init__.py Outdated Show resolved Hide resolved
diffsync/store/__init__.py Outdated Show resolved Hide resolved
diffsync/store/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, I just have two minor suggestions.

diffsync/store/__init__.py Outdated Show resolved Hide resolved
diffsync/store/__init__.py Show resolved Hide resolved
Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kircheneer Kircheneer merged commit f6afd05 into networktocode:develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants