-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation around ordering #170
Merged
Kircheneer
merged 4 commits into
networktocode:develop
from
itdependsnetworks:order-docs
Oct 21, 2022
Merged
Add documentation around ordering #170
Kircheneer
merged 4 commits into
networktocode:develop
from
itdependsnetworks:order-docs
Oct 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itdependsnetworks
requested review from
glennmatthews,
Kircheneer and
chadell
as code owners
October 18, 2022 12:14
Kircheneer
requested changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot, this answers a question I had in the beginning as well. Since we have dropped Python 3.6 support we are also safe to rely on the fact that dictionaries are ordered now, so that's good.
Kircheneer
reviewed
Oct 19, 2022
Kircheneer
previously approved these changes
Oct 20, 2022
glennmatthews
previously approved these changes
Oct 20, 2022
Co-authored-by: Glenn Matthews <[email protected]>
itdependsnetworks
dismissed stale reviews from glennmatthews and Kircheneer
via
October 20, 2022 23:49
8490fc8
glennmatthews
approved these changes
Oct 21, 2022
Kircheneer
pushed a commit
that referenced
this pull request
Nov 8, 2022
* Add documentation around ordering * update note * Update docs and add diag * Update docs/source/getting_started/01-getting-started.md Co-authored-by: Glenn Matthews <[email protected]> Co-authored-by: Glenn Matthews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.