Add 'skip' counter to diff.summary() #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubaumann
requested review from
glennmatthews,
Kircheneer and
chadell
as code owners
|
This implementation only works on the Diff object and not with the DiffElement. At the moment My first idea was to implement the solution in the DiffElement class, but when a model is skipped, there is no DiffElement returned. Changing this would probably bring more changes, so I decided to first make a simple solution and see what you think about. I appreciate feedback and can change the code accordingly. |
chadell
reviewed
Oct 15, 2022
Kircheneer
requested changes
Oct 17, 2022
itdependsnetworks
pushed a commit
to itdependsnetworks/diffsync
that referenced
this pull request
Oct 30, 2022
* Add 'skip' to diff.summary() * Fix location of variable and comment * Update summary in example 6 * Add comment to skip callculation in diff.summary()
Kircheneer
pushed a commit
that referenced
this pull request
Nov 8, 2022
* Add 'skip' to diff.summary() * Fix location of variable and comment * Update summary in example 6 * Add comment to skip callculation in diff.summary()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89
Adding the processed model counter to the Diff object to be able to calculate the number of skipped models.