Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example05 #107

Merged
merged 22 commits into from
Jun 30, 2022
Merged

Update example05 #107

merged 22 commits into from
Jun 30, 2022

Conversation

chadell
Copy link
Collaborator

@chadell chadell commented Apr 24, 2022

still adding some new content

To be updated when #106 is merged

@chadell chadell changed the title [WIP] Update example05 Update example05 Jun 8, 2022
@chadell chadell marked this pull request as ready for review June 8, 2022 12:37
@chadell chadell requested a review from glennmatthews as a code owner June 8, 2022 12:37
@@ -4,63 +4,72 @@

The goal of this example is to synchronize some data from [PeeringDB](https://www.peeringdb.com/), that as the name suggests is a DB where peering entities define their facilities and presence to facilitate peering, towards [Nautobot Demo](https://demo.nautobot.com/) that is a always on demo service for [Nautobot](https://nautobot.readthedocs.io/), an open source Source of Truth.

In Peering DB there is a model that defines a `Facility` and you can get information about the actual data center and the city where it is placed. In Nautobot, this information could be mapped to the `Region` and `Site` models, where `Region` can define hierarchy. For instance, Barcelona is in Spain and Spain is in Europe, and all of them are `Regions`. And, finally, the actual datacenter will refer to the `Region` where it is placed.
In Peering DB there is a model that defines a `Facility` and you can get information about the actual data center and the city where it is placed. In Nautobot, this information could be mapped to the `Region` and `Site` models, where `Region` can depend from other `Region` and also contain `Site` as children. For instance, Barcelona is in Spain and Spain is in Europe, and all of them are `Regions`. And, finally, the actual datacenter will refer to the `Region` where it is placed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - should that last sentence be amended to indicate that that the datacenter would be a Site associated with the Barcelona Region?

examples/05-nautobot-peeringdb/README.md Outdated Show resolved Hide resolved
examples/05-nautobot-peeringdb/README.md Outdated Show resolved Hide resolved
examples/05-nautobot-peeringdb/README.md Outdated Show resolved Hide resolved
examples/05-nautobot-peeringdb/README.md Show resolved Hide resolved
examples/05-nautobot-peeringdb/dockerfile Outdated Show resolved Hide resolved
examples/05-nautobot-peeringdb/main.py Outdated Show resolved Hide resolved
examples/05-nautobot-peeringdb/main.py Show resolved Hide resolved
examples/05-nautobot-peeringdb/requirements.txt Outdated Show resolved Hide resolved
python-slugify
pycountry
requests
IPython
pynautobot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any minimum pynautobot version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary

@chadell chadell requested a review from glennmatthews June 10, 2022 05:33
@Kircheneer
Copy link
Collaborator

Should the destination branch be develop here?

@chadell
Copy link
Collaborator Author

chadell commented Jun 29, 2022

Should the destination branch be develop here?

yes, but there was no develop branch when this PR was created. It would be great to unblock it. Feel free to complete it

@glennmatthews glennmatthews changed the base branch from main to develop June 30, 2022 17:18
glennmatthews
glennmatthews previously approved these changes Jun 30, 2022
examples/05-nautobot-peeringdb/dockerfile Outdated Show resolved Hide resolved
@glennmatthews glennmatthews merged commit c13cb05 into develop Jun 30, 2022
@glennmatthews glennmatthews deleted the example05-update branch June 30, 2022 18:29
@glennmatthews glennmatthews mentioned this pull request Jun 30, 2022
glennmatthews added a commit that referenced this pull request Jun 30, 2022
* New Example06 - IP Prefixes (#111)

* first draft of example06

Co-authored-by: Glenn Matthews <[email protected]>

* Attempt to fix the read the docs pipeline. (#115)

* Attempt to fix the read the docs pipeline.

* Yamllint.

Co-authored-by: Leo Kirchner <[email protected]>

* Update CODEOWNERS (#113)

* Fix get() by modelname (#118)

* Update example05 (#107)

* Update example05

* Use site as children

* Add update after adding children

* Add pylint disable until Redis code is in

* Update example

* simplify

* wip

* wip

* Update example

* Take redis from main

* imprort order

* yml

* update readme

* Use diffsync from pypi

* Apply suggestions from code review

Co-authored-by: Glenn Matthews <[email protected]>

* Code review

* replace bash by python exec

* Rename dockerfile to Dockerfile

* Update docs source

Co-authored-by: Glenn Matthews <[email protected]>

* Update CHANGELOG and bump version

Co-authored-by: Christian Adell <[email protected]>
Co-authored-by: Leo Kirchner <[email protected]>
Co-authored-by: Leo Kirchner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants