Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update development dependencies #103

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Update development dependencies #103

merged 1 commit into from
Mar 3, 2022

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Mar 2, 2022

This update update all the dev dependencies to the latest version

I couldn't install some dev dependencies on Python 3.9 because the lock file what pointing at a specific version of typed-ast that isn't support on Mac M1

@dgarros dgarros requested a review from glennmatthews as a code owner March 2, 2022 22:27
glennmatthews
glennmatthews approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with reservations - I feel like dependency = "*" is asking for trouble in the future, even for dev-only dependencies.

@dgarros
Copy link
Contributor Author

dgarros commented Mar 3, 2022

thanks

@dgarros dgarros merged commit 71cff0a into main Mar 3, 2022
@dgarros dgarros deleted the dga-update-deps branch March 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgarros @glennmatthews