Error handling for remote Geo service #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pke11y
requested review from
carbonarok,
chadell and
glennmatthews
as code owners
chadell
reviewed
Oct 13, 2021
circuit_maintenance_parser/utils.py
Outdated
| ) # TODO: Offline loading of timezone location data is quite slow. Look for better alternative | ||
| return timezone.tzNameAt(location.latitude, location.longitude) | ||
| except (GeocoderUnavailable, GeocoderTimedOut, GeocoderServiceError): | ||
| raise RemoteGeoAPIError( # pylint: disable=raise-missing-from |
There was a problem hiding this comment.
are we handling this exception raise? I mean, we are changing the expection object, but it's still a exception :)
There was a problem hiding this comment.
ah of course, good point. ParserError would be a better option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error handling for the remote Geo service that provides the timezone based on city name. This function is in the
utilsmodule and is currently used by the Cogent parser.Fixes #43