Handle more potential Lumen statuses seen in the field #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
requested review from
carbonarok,
chadell and
pke11y
as code owners
chadell
approved these changes
Sep 29, 2021
|
The samples I have fully pass existing parsing except for the differing status values, so I wasn't sure they were worth adding as additional test cases. I can redact them and add them as tests if you think it's worthwhile. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the potential Lumen status values of "Not Completed" and "Postponed", as seen in actual emails.
Additionally, for some updates to an existing maintenance, there is no column in the table describing the status. To avoid an error in this case (status is a mandatory field), I'm setting the status to a default of "CONFIRMED" - is this the best way to handle this?