AWS Direct Parser #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonarok
requested review from
chadell,
glennmatthews and
pke11y
as code owners
chadell
reviewed
Sep 27, 2021
circuit_maintenance_parser/parser.py
Outdated
| def parser_hook(self, raw: bytes): | ||
| """Execute parsing.""" | ||
| result = [] | ||
| soup = bs4.BeautifulSoup(quopri.decodestring(raw), features="lxml") |
There was a problem hiding this comment.
does this look like a Html parser? maybe we should add the text/plain into that data_type. I see it too much HTML specific for a generic Text parser
chadell
reviewed
Sep 27, 2021
| maintenace_id += str(data["start"]) | ||
| data["end"] = self.dt2ts(parser.parse(search.group(2))) | ||
| if "may become unavailable" in line.lower(): | ||
| impact = "DEGRADED" |
chadell
reviewed
Sep 27, 2021
chadell
reviewed
Sep 28, 2021
| _processors: List[GenericProcessor] = [ | ||
| CombinedProcessor(data_parsers=[EmailDateParser, TextParserAWS1, SubjectParserAWS1]), | ||
| ] | ||
| _default_organizer = "aaaaaaaaaaaaaaa" |
chadell
reviewed
Sep 28, 2021
tests/unit/data/aws/aws1_result.json
Outdated
| ], | ||
| "end": 1621519200, | ||
| "maintenance_id": "21264c558a1b6a2bedaae0878d6318b0", | ||
| "organizer": "aaaaaaaaaaaaaaa", |
chadell
reviewed
Sep 28, 2021
circuit_maintenance_parser/parser.py
Outdated
| """Execute parsing.""" | ||
| result = [] | ||
| soup = bs4.BeautifulSoup(quopri.decodestring(raw), features="lxml") | ||
| # Even we have not noticed any HTML notification with more than one maintenance yet, we define the |
There was a problem hiding this comment.
this is not true :) , we have Sparkle
chadell
reviewed
Sep 28, 2021
circuit_maintenance_parser/parser.py
Outdated
|
|
||
|
|
||
| class Text(Parser): | ||
| """Html parser.""" |
chadell
reviewed
Sep 28, 2021
| if "may become unavailable" in line.lower(): | ||
| impact = Impact.OUTAGE | ||
| elif "has been cancelled" in line.lower(): | ||
| impact = Impact.NO_IMPACT |
There was a problem hiding this comment.
I would not change the impact type, even Cancelled
…tenance-parser into kc_aws_parser
chadell
reviewed
Sep 28, 2021
circuit_maintenance_parser/parser.py
Outdated
| return result | ||
|
|
||
| @staticmethod | ||
| def get_text_hook(raw): |
There was a problem hiding this comment.
Suggested change
| def get_text_hook(raw): | |
| def get_text_hook(raw: bytes) -> str: |
chadell
previously approved these changes
Sep 28, 2021
chadell
approved these changes
Sep 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser for AWS notifications