AquaComms #75
Merged
AquaComms #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonarok
requested review from
chadell,
glennmatthews and
pke11y
as code owners
chadell
reviewed
Sep 14, 2021
| ], | ||
| "end": 1602572400, | ||
| "maintenance_id": "11111", | ||
| "organizer": "[email protected]", |
chadell
reviewed
Sep 14, 2021
| _processors: List[GenericProcessor] = [ | ||
| CombinedProcessor(data_parsers=[EmailDateParser, HtmlParserAquaComms1, SubjectParserAquaComms1]), | ||
| ] | ||
| _default_organizer = "[email protected]" |
|
Talk to me about that last commit, please - why shouldn't we be reading the timezone when parsing the email? |
chadell
reviewed
Sep 14, 2021
| @@ -0,0 +1,78 @@ | |||
| """Turkcell parser.""" | |||
There was a problem hiding this comment.
Suggested change
| """Turkcell parser.""" | |
| """AquaComms parser.""" |
glennmatthews
previously approved these changes
Sep 14, 2021
carbonarok
dismissed stale reviews from glennmatthews and chadell
via
3c0a638
glennmatthews
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New provider and parser added for AquaComms.