-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-58: Ensure safety usage of the init_data methods #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of these init_data_*
methods? They seem like just really thin wrappers around Notificationdata.init*
methods - why would I call these instead of calling those directly?
Yes, it is really "thinner" than my initial idea, but the main purpose is to expose a method to the client to avoid it know about the internal library details/classes, so, instead of using |
Co-authored-by: Glenn Matthews <[email protected]>
Addresses issue #58
Ensure
try/except
pattern for any issue found while initializingNotificationData
from the library client, returning empty data.I know it's too open, but because there could be multiple errors I tried to make it the simplest in the code instead of documenting all the potential exceptions each method could raise.