HGC Parser #68
Merged
HGC Parser #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
reviewed
Sep 7, 2021
| """Parse HGC subject string.""" | ||
| data = {} | ||
| try: | ||
| search = re.search(r"^.+\((.+)\)", subject.replace("\n", "")) |
There was a problem hiding this comment.
can you add an example of this parser? (easy to understand the regex)
chadell
reviewed
Sep 7, 2021
Comment on lines
27
to
36
| try: | ||
| search = re.search(r"^.+\((.+)\)", subject.replace("\n", "")) | ||
| if search: | ||
| data["maintenance_id"] = search.group(1) | ||
| else: | ||
| split = subject.split(" | ") | ||
| data["maintenance_id"] = split[2] | ||
| return [data] | ||
| except Exception as exc: | ||
| raise ParserError from exc |
There was a problem hiding this comment.
Suggested change
| try: | |
| search = re.search(r"^.+\((.+)\)", subject.replace("\n", "")) | |
| if search: | |
| data["maintenance_id"] = search.group(1) | |
| else: | |
| split = subject.split(" | ") | |
| data["maintenance_id"] = split[2] | |
| return [data] | |
| except Exception as exc: | |
| raise ParserError from exc | |
| search = re.search(r"^.+\((.+)\)", subject.replace("\n", "")) | |
| if search: | |
| data["maintenance_id"] = search.group(1) | |
| else: | |
| split = subject.split(" | ") | |
| data["maintenance_id"] = split[2] | |
| return [data] |
the main parse method is taking care of this (merge from develop!)
chadell
previously approved these changes
Sep 7, 2021
|
|
||
|
|
||
| class HtmlParserHGC2(Html): | ||
| """HGC HTML parser.""" |
There was a problem hiding this comment.
Suggested change
| """HGC HTML parser.""" | |
| """HGC HTML 2 parser.""" |
|
|
||
|
|
||
| class HtmlParserHGC1(Html): | ||
| """HGC HTML parser.""" |
There was a problem hiding this comment.
Suggested change
| """HGC HTML parser.""" | |
| """HGC HTML 1 parser.""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New HGC parser created