Colt Parser #61
Merged
Colt Parser #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pke11y good work! going on the right direction! |
chadell
reviewed
Sep 6, 2021
chadell
reviewed
Sep 6, 2021
tests/unit/test_providers.py
Outdated
| @@ -10,6 +10,7 @@ | |||
| from circuit_maintenance_parser.provider import ( | |||
| GenericProvider, | |||
| Cogent, | |||
| Colt, | |||
There was a problem hiding this comment.
I know this was the pattern before, but this is gonna change, so better if you do not update this file, less conflicts to fix :)
There was a problem hiding this comment.
Ah ok, I see the other PR now. Will remove.
|
#56 PR is merged ;) |
chadell
reviewed
Sep 6, 2021
Comment on lines
48
to
55
| # organizer = ( | ||
| # str(component.get("ORGANIZER")) if component.get("ORGANIZER") else self.default_organizer | ||
| # ) | ||
| # provider = ( | ||
| # str(component.get("X-MAINTNOTE-PROVIDER")) | ||
| # if component.get("X-MAINTNOTE-PROVIDER") | ||
| # else self.default_provider | ||
| # ) |
There was a problem hiding this comment.
Suggested change
| # organizer = ( | |
| # str(component.get("ORGANIZER")) if component.get("ORGANIZER") else self.default_organizer | |
| # ) | |
| # provider = ( | |
| # str(component.get("X-MAINTNOTE-PROVIDER")) | |
| # if component.get("X-MAINTNOTE-PROVIDER") | |
| # else self.default_provider | |
| # ) |
chadell
reviewed
Sep 6, 2021
|
|
||
| data = { | ||
| "circuits": [], | ||
| # "provider": provider, |
There was a problem hiding this comment.
Suggested change
| # "provider": provider, |
chadell
reviewed
Sep 6, 2021
Comment on lines
73
to
74
| # "organizer": organizer, | ||
| # "uid": str(component.get("UID")), |
There was a problem hiding this comment.
Suggested change
| # "organizer": organizer, | |
| # "uid": str(component.get("UID")), |
chadell
reviewed
Sep 6, 2021
chadell
reviewed
Sep 6, 2021
chadell
reviewed
Sep 6, 2021
chadell
reviewed
Sep 6, 2021
chadell
reviewed
Sep 7, 2021
chadell
reviewed
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for the Colt parser. Adds new CSV type base parser.
WIP: further tests to be added once #56 is merged. Currently this is required to ensure e2e email test is successful.
Includes individual tests for each attachment - iCal and CSV.
Adds
emailtype to the e2e tests using.emlfile with.icsand.csvattachments.