Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #59: Take Stamp from Email Date #59

Merged
merged 6 commits into from
Sep 6, 2021
Merged

issue #59: Take Stamp from Email Date #59

merged 6 commits into from
Sep 6, 2021

Conversation

chadell
Copy link
Collaborator

@chadell chadell commented Sep 4, 2021 •
edited
Loading

Addresses #59

  • Create a new parser to take the Stamp from the Email data
  • Use the Parser in most of the HTML based Providers, using CombinedProcessor instead of the SimplerProcessor

@chadell chadell changed the title issue #56: Take Stamp from Email Date issue #59: Take Stamp from Email Date Sep 4, 2021
@chadell chadell requested review from carbonarok and pke11y September 4, 2021 08:45
carbonarok
carbonarok previously approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@carbonarok carbonarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

circuit_maintenance_parser/parser.py
_data_types = ["email-header-date"]

def parse(self, raw: bytes) -> List[Dict]:
"""Method that returns a list of Maintenance objects."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method only support specific formats of dates?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only supports Email Date format

@chadell chadell merged commit c589145 into develop Sep 6, 2021
@chadell chadell deleted the issue-56-stamp-parser branch September 6, 2021 13:58
@chadell chadell mentioned this pull request Sep 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonarok carbonarok carbonarok left review comments

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadell @carbonarok