Add a Verizon parser #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
previously approved these changes
Aug 23, 2021
| """Execute parsing.""" | ||
| data = data_base.copy() | ||
| try: | ||
| logger.debug("PARSING") |
There was a problem hiding this comment.
parsing what? maybe a more detailed message would help :)
There was a problem hiding this comment.
That was only temporary, but will keep and add more detail if that works. Can remove if required.
| """Verizon provider custom class.""" | ||
|
|
||
| _parser_classes: Iterable[Type[Parser]] = [HtmlParserVerizon1] | ||
| _default_organizer = "[email protected]" |
There was a problem hiding this comment.
maybe not the most "generic" email, but until we don't have other, it should work
There was a problem hiding this comment.
agreed, but the only one we have right now.
glennmatthews
previously approved these changes
Aug 23, 2021
Co-authored-by: Glenn Matthews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an email parser for Verizon circuit maintenance notifications.
Unit/Provider tests included: